Handle empty zones correctly

nbuchwitz · Aug 13, 2018 · c131a77 · c131a77
1 parent 273b6dc
commit c131a77
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/nc_dnsapi/__init__.py b/nc_dnsapi/__init__.py
@@ -85,6 +85,9 @@ def request(self, action, **kwargs):
 
             if data['status'] == 'success':
                 return data
+            # empty dns zone
+            elif data['statuscode'] == 5029:
+                return []
             else:
                 raise Exception("{} ({})".format(data['longmessage'], data['statuscode']))
         else:
@@ -116,6 +119,9 @@ def update_dns_records(self, domain, records):
             "dnsrecordset": {"dnsrecords": [record.__dict__ for record in records]}
         })
 
+        if 'responsedata' not in data:
+            return []
+
         return [DNSRecord(**r) for r in data['responsedata']['dnsrecords']]
 
     def dns_record_exists(self, domain, record):
@@ -152,6 +158,10 @@ def delete_dns_records(self, domain, records):
 
     def dns_records(self, domain):
         data = self.request("infoDnsRecords", params={"domainname": domain})
+
+        if 'responsedata' not in data:
+            return []
+
         return [DNSRecord(**r) for r in data['responsedata']['dnsrecords']]
 
     def update_dns_zone(self, domain, zone):