Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable ssl security #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enable ssl security #28

wants to merge 1 commit into from

Conversation

roufa85
Copy link
Contributor

@roufa85 roufa85 commented Jul 16, 2019

@nbogojevic please review this PR after #29
Thanks!

@codecov-io
Copy link

codecov-io commented Jul 16, 2019

Codecov Report

Merging #28 into master will increase coverage by 19.85%.
The diff coverage is 83.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #28       +/-   ##
=============================================
+ Coverage     58.34%   78.19%   +19.85%     
- Complexity      211      218        +7     
=============================================
  Files            30       27        -3     
  Lines          1037      798      -239     
  Branches         55       37       -18     
=============================================
+ Hits            605      624       +19     
+ Misses          405      148      -257     
+ Partials         27       26        -1
Impacted Files Coverage Δ Complexity Δ
...java/nb/kafka/operator/TopicCreationException.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...main/java/nb/kafka/operator/util/MeterManager.java 95.83% <ø> (+16.52%) 10 <0> (ø) ⬇️
...main/java/nb/kafka/operator/util/PropertyUtil.java 74% <ø> (+2.84%) 23 <0> (-1) ⬇️
...rc/main/java/nb/kafka/operator/KafkaAdminImpl.java 79.54% <0%> (-5.83%) 11 <0> (ø)
src/main/java/nb/kafka/operator/Main.java 59.32% <100%> (+2.95%) 3 <0> (ø) ⬇️
src/main/java/nb/kafka/operator/AppConfig.java 99.08% <100%> (+0.14%) 46 <10> (+8) ⬆️
...n/java/nb/kafka/operator/importer/CrdImporter.java
src/main/java/nb/kafka/operator/AclManager.java
.../java/nb/kafka/operator/watch/TopicCrdWatcher.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e368be...be4c5b1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants