Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsx: fix regression that made fsxc misbehave #44

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Commits on Sep 3, 2024

  1. fsx: fix regression that made fsxc misbehave

    In a geewallet's PR[1] I bisected the problem to this commit:
    dd66eb3.
    
    So I'm basically reverting that commit here, but I still don't
    understand why it would cause such a regression. The problem
    is that fsxc is not able to compile anymore certain scripts
    and spits some errors that look to be warnings, such as:
    
    ```
    Error: D:\a\geewallet\geewallet\scripts\bin\downloadUbuntuDeps.fsx.fs(14,1): error FS0020: The result of this expression has type 'int' and is implicitly ignored. Consider using
    'ignore' to discard this value explicitly, e.g. 'expr |> ignore', or 'let' to bind the result to a name, e.g. 'let result = expr'.
    [D:\a\geewallet\geewallet\scripts\bin\downloadUbuntuDeps.fsx.fsproj]
    ```
    
    [1] nblockchain/geewallet#289
    knocte committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    8891a9f View commit details
    Browse the repository at this point in the history