-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts to apply and check the style of F#, C#, TS, YMl and XAML files #103
base: master
Are you sure you want to change the base?
Add scripts to apply and check the style of F#, C#, TS, YMl and XAML files #103
Conversation
f3730c7
to
18c175b
Compare
Please change GitHubCI to use this script also. |
3339696
to
67cd86e
Compare
Done |
67cd86e
to
07c3a8f
Compare
296f06f
to
396169b
Compare
I guess you meant |
396169b
to
4c213d1
Compare
Right |
6170a1c
to
76f356d
Compare
fd95db8
to
1d801bf
Compare
1d801bf
to
482347c
Compare
a88a403
to
c185305
Compare
Added some comments in tehraninasab@2ecf57b |
2f45679
to
c7b0b00
Compare
Added another comment in c7b0b00 |
@realmarv please address the comments above. And stop working on another task before you finish this one please. I told you that you shouldn't start new tasks before you finish old ones, and you keep working on a new task that you decided to start some days ago. This PR needs to be merged first before you resume work on that. BTW how is NX going? I don't see you chasing people to merge PRs and the like. (The fact that I assigned a task to Taras doesn't mean loss of focus on NX, I just gave him one extra low-prio task.) |
c7b0b00
to
e79352e
Compare
I don't see any comment there |
Sorry I thought I addressed those comments |
e2a80b2
to
a35c6cb
Compare
Do you see this one?: tehraninasab@2ecf57b |
ce5c213
to
3c55518
Compare
Before I merge this PR, @aarani can you test the styleApply.fsx script independently? |
3c55518
to
2ec433e
Compare
Add styleChecker.fsx script to check style of our F#, TS and YML codes. The `git respore package.json` command in the styleChecker.fsx script was failing with the following error, even when I was running the `git config --global --add safe.directory '*'` command in both the styleChecker.fsx script and in the CI. In the issue [1], it's suggested by someone to use --system instead of --global in the mentioned command, when the git command is running in a container, which solved the problem. ``` fatal: detected dubious ownership in repository at '/__w/conventions/conventions' To add an exception for this directory, call: git config --global --add safe.directory /__w/conventions/conventions Error when running 'git restore package.json' Fsdk.Process+ProcessFailed: Exception of type 'Fsdk.Process+ProcessFailed' was thrown. at Fsdk.Process.ProcessResult.Unwrap(String errMsg) at Fsdk.Process.ProcessResult.UnwrapDefault() at FSI_0002.RunPrettier(String arguments) at <StartupCode$FSI_0002>.$FSI_0002.main@() Stopped due to error Error: Process completed with exit code 1. ``` [1] actions/checkout#1048
561f306
to
444ea54
Compare
Split styleChecker into styleCheck and styleApply.
444ea54
to
6a89659
Compare
styleApply.fsx doesn't work on windows
|
Wrong commit msg: restore -> resprose |
Ah also YMI -> YML |
@parhamsaremi can you test running styleApply.fsx in your Linux OS (which I guess is ubuntu22.04.x) please. |
Add styleChecker.fsx script to check style of our F#, TS
and YML codes.
The
git respore package.json
command in thestyleChecker.fsx script was failing with the following
error, even when I was running the
git config --global --add safe.directory '*'
command inboth the styleChecker.fsx script and in the CI. In the
issue [1], it's suggested by someone to use --system
instead of --global in the mentioned command, when the
git command is running in a container, which solved the
problem.
[1] actions/checkout#1048