Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Newtonsoft.Json with System.Text.Json #21

Merged
merged 3 commits into from
Feb 15, 2024

Commits on Feb 12, 2024

  1. Core,Tests: replace Newtonsoft.Json with STJ

    Replace Newtonsoft.Json with System.Text.Json so that we don't
    have different libraries for JSON, because System.Text.Json
    will be used by GRPC services.
    webwarrior-ws committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    343abd5 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Tests: use System.Text.Json in integration tests

    Use System.Text.Json instead of Newtonsoft.Json in integration
    tests.
    webwarrior-ws committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2356027 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Core: add json converters for F# types

    Implement JSON converters for F# Discriminated Union types
    because System.Text.Json can't serialize them out of the box.
    Without converters, got the following error:
    ```
    System.NotSupportedException : F# discriminated union serialization is not supported. Consider authoring a custom converter for the type.
    The unsupported member type is located on type 'FsharpExchangeDotNetStandard.Currency'. Path: $.Market.BuyCurrency.
    ```
    webwarrior-ws committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    055624e View commit details
    Browse the repository at this point in the history