Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place a heading that says'Pictures'before the picture of the dog. Include an appropricte icon #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rendertolearn
Copy link

Added a heading "Pictures" to heading 2 and camera icon below
screenshot-added_heading-icon

@rendertolearn
Copy link
Author

Hi, I added a heading (Pictures) and an icon (camera) to issue #35 and am awaiting your approval.

@@ -32,7 +33,8 @@ <h1>Excepteur Sint Occaecat</h1>
</a>
</li>
</ul>
<h2 class="point">Duis Aute</h2>
<h2 class="point">Pictures</h2>
Copy link
Member

@nbkhope nbkhope Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Hi, the heading should be immediately before the <img>, not the paragraph.

  2. You should place the icon to the left-hand side of the text Pictures, like this: 📷Pictures
    You can just move the <i> tag inside the <h2>.

image

@nbkhope
Copy link
Member

nbkhope commented Jun 21, 2024

Next time, please create a feature branch instead of committing directly to master.

Every time you start work you would do

git checkout -b describe-the-feature-like-this
# ... do the work...
git push origin describe-the-feature-like-this

Then the pull request would say at the top

rendertolearn wants to merge 1 commit into nbktechworld:master from rendertolearn:describe-the-feature-like-this

instead of

rendertolearn wants to merge 1 commit into nbktechworld:master from rendertolearn:master 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants