Store a reference to environment in session to tie its lifetime #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By storing a reference to the environment, a session cannot be built in a specific way that causes segmentation faults. This forces a let binding on the environment.
Unfortunately, the fix prevents the monomorphization trick employed for
with_model_from_file()
which had to be merged withwith_model_from_file_monomorphized()
. Since this should only be called once per program, I guess the cost is not that much.Closes #42