Fix basePath bug and add details to various validation debug messages. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update module name passed to debug so that it matches both the instru…
…ed from the middle of a URL.
mschaef-da
commented
Dec 4, 2018
| const matchUrlWithSchema = (reqUrl) => { | ||
| let url = parseUrl(reqUrl).pathname; | ||
| if (options.schema.basePath) { | ||
| url = url.replace(options.schema.basePath, ''); |
There was a problem hiding this comment.
The original code will replace occurrences of the basepath that occur in the middle of the input URL. (As long as they are the first such instance.)
> const basePath = '/b';
undefined
> '/a/b/c/d'.replace(basePath, '')
'/a/c/d'
mschaef-da
commented
Dec 4, 2018
| @@ -136,7 +144,7 @@ const validateResponse = (req, res, next) => { | |||
|
|
|||
| const responseSchema = resolveResponseModelSchema(req, res); | |||
| if (!responseSchema) { | |||
| debug('Response validation skipped: no matching response schema'); | |||
| debug(`Response validation skipped: no matching response schema for ${req.method} ${req.originalUrl}`); | |||
There was a problem hiding this comment.
The intent behind these changes is to make it easier to see which requests are not covered by a given schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.