Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.7, 3.8 #239

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Drop python 3.7, 3.8 #239

merged 7 commits into from
Jan 9, 2024

Conversation

clbarnes
Copy link
Collaborator

No description provided.

@clbarnes clbarnes changed the title Drop python 3.7 Drop python 3.7, 3.8 Nov 14, 2023
@clbarnes
Copy link
Collaborator Author

3.8 is not deprecated according to PSF, but to numpy, which is a community standard among scientific packages.

While it is still supported by PSF, it is deprecated by numpy's policy,
which is a community standard among scientific packages.
@clbarnes
Copy link
Collaborator Author

clbarnes commented Jan 5, 2024

The remaining test failures (locally at least) are

  • from navis' use of csgraph using u32 instead of u64 internally, which I guess isn't being hit in navis' tests?
  • from VFB's FAFB instance docker setup having a shared memory size limit which is being hit when fetching the tag table, see https://groups.google.com/g/vfb-suport/c/4yJWTKWr2fo

@clbarnes
Copy link
Collaborator Author

clbarnes commented Jan 5, 2024

The sparse graph thing is very odd, it works fine in navis, the data types seem to be the same in pymaid. If you turn the sparse adjacency matrix into a dense one and back again it works fine as well.

@clbarnes
Copy link
Collaborator Author

clbarnes commented Jan 9, 2024

The navis tests are not actually testing the no-igraph case, see navis-org/navis#139

@clbarnes clbarnes merged commit 647d688 into master Jan 9, 2024
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant