Bugfix/idporten cors #3653
Merged
Bugfix/idporten cors #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#deploy-idporten-frontend
#deploy-idporten-frontend
#deploy-idporten-frontend
krharum
approved these changes
Oct 15, 2024
| @@ -78,10 +80,17 @@ public SecurityWebFilterChain configure(ServerHttpSecurity http, ServerOAuth2Aut | |||
| ).permitAll() | |||
| .anyExchange().authenticated()) | |||
| .oauth2Login(oAuth2LoginSpec -> oAuth2LoginSpec | |||
| .authenticationFailureHandler((webFilterExchange, exception) -> { | |||
| log.error("Failed to authenticate user", exception); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve error handling, logging, and configuration in the
dolly-frontendapplication. The most important changes include adding error handling in theIdportenSecurityConfigclass, modifying theLogControllerandSessionControllerfor better error logging, and updating the React components and configuration files for enhanced error reporting and build optimization.The issue itself was not in our app, but with outdated credentials in the custom bankid client we use, but with better logging we can catch issues like this earlier.
Error Handling Improvements:
apps/dolly-frontend/src/main/java/no/nav/dolly/web/config/IdportenSecurityConfig.java: Added error logging in theauthenticationFailureHandlerfor both OAuth2 and form login to better capture authentication failures.Logging Enhancements:
apps/dolly-frontend/src/main/java/no/nav/dolly/web/provider/web/LogController.java: Refactored theloggmethod to useMono.fromCallablefor improved logging.apps/dolly-frontend/src/main/java/no/nav/dolly/web/provider/web/SessionController.java: Added error logging in theaddUserToSessionmethod to capture errors during access checks and session storage. [1] [2]Frontend Error Reporting:
apps/dolly-frontend/src/main/js/src/RootComponent.tsx: MovedErrorBoundaryto wrap the entireRootComponentto catch errors at a higher level. [1] [2]apps/dolly-frontend/src/main/js/src/components/ui/appError/AppError.tsx: Added error logging in theuseEffecthook to report unknown errors in theAppErrorcomponent.apps/dolly-frontend/src/main/js/src/components/utlogging/navigateToLogin.tsx: Enhanced error message logging in thenavigateToLoginfunction.Build Configuration:
apps/dolly-frontend/src/main/js/vite.config.js: AddedrollupOptionsto excludenais.jsfrom the build for better optimization.