Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bytte endepukter til kodeverk service #3454

Merged
merged 11 commits into from
Apr 4, 2024

Conversation

krharum
Copy link
Contributor

@krharum krharum commented Apr 4, 2024

No description provided.

Replaced GeografiskeKodeverkConsumer with KodeverkConsumer across the application. Adjustments done in methods and tests to align with this change. This allows us to use KodeverkConsumer more consistently throughout the project, simplifying the code structure and maintainability.
#deploy-test-dolly-backend

Revised Kodeverk implementation to utilize testnav-kodeverk-service instead of kodeverk-api. This involved changes to consumers configuration, property files, and KodeverkConsumer. Corresponding Mapper and Controller methods were removed, and unused test cases were deleted. This change is aimed at simplifying the codebase and removing redundant dependencies.
This commit incorporates the KodeverkService to interact with the Kodeverk API and fetch specific kodeverk based on its name. The changes involve new routing to the Kodeverk API and replacement of DollyBackend in fetching kodeverk with the new KodeverkService.
@krharum krharum requested a review from a team as a code owner April 4, 2024 05:50
Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supert 😄

#deploy-test-dolly-backend #deploy-test-dolly-frontend

Added a log.info() line in KodeverkConsumer to log the responses it receives when getting the "kodeverk". Additionally, unnecessary CACHE_KODEVERK and CACHE_KODEVERK_2 constant were removed from CachingConfig, along with their associated initialization in the CaffeineCacheManager, resulting in a streamlined cache configuration and reduced overhead.
The GeografiskeKodeverkDTO class in the data-transfer-objects library was removed, as it was no longer necessary for the functionality of the system. This change simplifies the project structure and reduces the complexity of the data transfer process between frontend and backend.
#deploy-test-dolly-backend #deploy-test-dolly-frontend

Added a log.info() line in KodeverkConsumer to log the responses it receives when getting the "kodeverk". Additionally, unnecessary CACHE_KODEVERK and CACHE_KODEVERK_2 constant were removed from CachingConfig, along with their associated initialization in the CaffeineCacheManager, resulting in a streamlined cache configuration and reduced overhead.
#deploy-test-dolly-backend

The URL for the testnav-kodeverk-service in the application.yaml file was updated to the new HTTPS URL used for the internal development environment. This ensures secure communication with the service and reflects the updated network infrastructure.
@krharum krharum merged commit 970de99 into master Apr 4, 2024
74 of 75 checks passed
@krharum krharum deleted the feature/bytte-endepukter-til-kodeverk-service branch April 4, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants