Skip to content

Commit

Permalink
**Refactor project structure and dependencies**
Browse files Browse the repository at this point in the history
Remove unnecessary DevConfig and centralize logic under oppdragservice package. Also, streamline build configuration by using dolly-apps plugin and integrating vault library for improved consistency and security management.
  • Loading branch information
krharum committed Oct 15, 2024
1 parent d2f6105 commit 1ae4acc
Show file tree
Hide file tree
Showing 14 changed files with 26 additions and 76 deletions.
28 changes: 2 additions & 26 deletions apps/oppdrag-service/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,28 +10,16 @@ buildscript {
}

plugins {
id 'java'
id "org.sonarqube" version "4.4.1.3373"
id 'org.springframework.boot' version "3.2.1"
id 'io.spring.dependency-management' version "1.1.4"
id "jacoco"
id 'dolly-apps'
id "uk.co.boothen.gradle.wsimport" version "0.21"
}

apply plugin: "uk.co.boothen.gradle.wsimport"

sonarqube {
properties {
property "sonar.dynamicAnalysis", "reuseReports"
property "sonar.host.url", "https://sonarcloud.io"
property "sonar.java.coveragePlugin", "jacoco"
property "sonar.language", "java"
property "sonar.token", System.getenv("SONAR_TOKEN")
property "sonar.organization", "navikt"
property "sonar.project.monorepo.enabled", true
property "sonar.projectKey", "testnav-oppdrag-service"
property "sonar.projectName", "testnav-oppdrag-service"
property "sonar.sourceEncoding", "UTF-8"
}
}

Expand All @@ -54,19 +42,6 @@ wsimport {
target = "3.0"
}

dependencyManagement {
applyMavenExclusions = false
imports {
mavenBom 'org.springframework.cloud:spring-cloud-dependencies:2023.0.0'
}
}

java {
toolchain {
languageVersion = JavaLanguageVersion.of(21)
}
}

repositories {
mavenCentral()
maven {
Expand Down Expand Up @@ -97,6 +72,7 @@ dependencies {
implementation 'no.nav.testnav.libs:servlet-core'
implementation 'no.nav.testnav.libs:servlet-security'
implementation 'no.nav.testnav.libs:data-transfer-objects'
implementation "no.nav.testnav.libs:vault"

implementation 'org.springframework.cloud:spring-cloud-starter-vault-config'

Expand Down
1 change: 1 addition & 0 deletions apps/oppdrag-service/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ includeBuild '../../libs/security-core'
includeBuild '../../libs/servlet-core'
includeBuild '../../libs/servlet-security'
includeBuild '../../libs/data-transfer-objects'
includeBuild '../../libs/vault'

gradleEnterprise {
buildScan {
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package no.nav.testnav.oppdrag.service;
package no.nav.testnav.oppdragservice;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package no.nav.testnav.oppdrag.service.config;
package no.nav.testnav.oppdragservice.config;

import no.nav.testnav.libs.servletcore.config.ApplicationCoreConfig;
import no.nav.testnav.libs.servletsecurity.config.SecureOAuth2ServerToServerConfiguration;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package no.nav.testnav.oppdragservice.config;

import no.nav.testnav.libs.vault.AbstractLocalVaultConfiguration;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.Profile;
import org.springframework.vault.annotation.VaultPropertySource;

@Configuration
@Profile("dev")
@VaultPropertySource(value = "secret/dolly/lokal", ignoreSecretNotFound = false)
public class DevConfig extends AbstractLocalVaultConfiguration {

}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package no.nav.testnav.oppdrag.service.config;
package no.nav.testnav.oppdragservice.config;

import io.swagger.v3.oas.models.Components;
import io.swagger.v3.oas.models.OpenAPI;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package no.nav.testnav.oppdrag.service.config;
package no.nav.testnav.oppdragservice.config;

import no.nav.testnav.oppdrag.service.consumer.OppdragClient;
import no.nav.testnav.oppdragservice.consumer.OppdragClient;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.oxm.jaxb.Jaxb2Marshaller;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package no.nav.testnav.oppdrag.service.config;
package no.nav.testnav.oppdragservice.config;

import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package no.nav.testnav.oppdrag.service.consumer;
package no.nav.testnav.oppdragservice.consumer;

import lombok.extern.slf4j.Slf4j;
import org.springframework.ws.client.core.support.WebServiceGatewaySupport;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package no.nav.testnav.oppdrag.service.consumer;
package no.nav.testnav.oppdragservice.consumer;

import org.springframework.stereotype.Service;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package no.nav.testnav.oppdrag.service.provider;
package no.nav.testnav.oppdragservice.provider;

import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RequestMapping;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package no.nav.testnav.oppdrag.service;
package no.nav.testnav.oppdragservice;

import org.junit.jupiter.api.Test;
import org.springframework.boot.test.context.SpringBootTest;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@
@Data
@Builder
@NoArgsConstructor
@AllArgsConstructor
public class OppdragRequest {
}

0 comments on commit 1ae4acc

Please sign in to comment.