Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legend): Pass visibility state to legend item's event callback #3899

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

netil
Copy link
Member

@netil netil commented Oct 14, 2024

Issue

#3897

Details

Pass visibility state argument to event callbacks

legend
     item: {
         onclick: function(id, visible) {
          	// toggle based on the data visibility
          	this[visible ? "hide" : "show"](id);
         },
         onover: function(id, visible) { ... },
         onout: function(id, visible) { ... },
    }
}

@netil netil added the feature label Oct 14, 2024
@netil netil self-assigned this Oct 14, 2024
Pass visibility state argument to event callbacks

Ref naver#3897
@netil netil merged commit ba71911 into naver:master Oct 14, 2024
6 checks passed
@netil netil deleted the legend#3897 branch October 14, 2024 10:17
@coveralls
Copy link

Coverage Status

coverage: 94.247% (+0.02%) from 94.227%
when pulling a093fb6 on netil:legend#3897
into 6f69e97 on naver:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants