feat(render): Add forced init option on lazy rendering #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make to initialize when chart element isn't visible, but render.lazy=false is set Ref naver#3106
stof
reviewed
Sep 20, 2024
| // hook = () => { | ||
| // logError(`The call of APIs won't work. Please, make sure if chart element is %cvisible.`); | ||
| // }; | ||
| // } |
There was a problem hiding this comment.
shouldn't this has been removed ?
There was a problem hiding this comment.
Left for future consideration as comment.
| @@ -518,7 +518,7 @@ describe("Interface & initialization", () => { | |||
| })); | |||
|
|
|||
| it("check lazy rendering on callbacks", () => new Promise(done => { | |||
| const el: any = document.body.querySelector("#chart"); | |||
| const el = <HTMLDivElement>document.body.querySelector("#chart"); | |||
There was a problem hiding this comment.
the modern typescript way for that is to use the document.body.querySelector("#chart") as HTMLDivElement instead.
There was a problem hiding this comment.
Thanks for the suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3106
Details
Make to initialize when chart element isn't visible, but render.lazy=false is set