Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event): Fix interaction with viewBox #3877

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

netil
Copy link
Member

@netil netil commented Sep 10, 2024

Issue

#3414

Details

Fix basic interaction when scale is update with viewBox

// generation option used
bb.generate({
	size: {
		width: 320,
		height: 240
	},
	resize: { auto: false },
	data: {
		columns: [
			["data1", 300, 350, 300, 0, 0, 0],
			["data2", 130, 100, 140, 200, 150, 50]
		],
		type: "line"
	},
	onrendered() {
		this.$.svg
			.attr("viewBox", "0 0 320 240")
			.style("width", "100%")
			.style("height", "auto");
	}
});

Sep-10-2024 14-26-05

Fix basic interaction when scale is update with viewBox

Ref naver#3414
@netil netil self-assigned this Sep 10, 2024
@coveralls
Copy link

Coverage Status

coverage: 94.245% (-0.02%) from 94.263%
when pulling a163358 on netil:viewBox#3414
into e32ba57 on naver:master.

@netil netil merged commit 243bf3c into naver:master Sep 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants