Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legend): Provide original data id in format callback #3868

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

netil
Copy link
Member

@netil netil commented Aug 13, 2024

Issue

#3663

Details

When data.names option is specified, provide original data id to format callback

bb.generate({
  data: {
    names: {
      "data1": "Detailed Name",
      "data2": "Name Detailed"
    },
    columns: [
      ["data1", 71.4],
      ["data2", 10],
    ],
    type: "gauge"
  },
  legend: {
    format(id, dataId) {
       return id === "Name Detailed" ? dataId : id;
    },
    tooltip: true
  }
});

When data.names option is specified, provide original data id
to format callback

Ref naver#3663
@netil netil added the feature label Aug 13, 2024
@netil netil self-assigned this Aug 13, 2024
@coveralls
Copy link

Coverage Status

coverage: 94.263% (+0.001%) from 94.262%
when pulling 280cafa on netil:legend#3663
into 0c9fbc6 on naver:master.

@netil netil merged commit 5ce41c7 into naver:master Aug 13, 2024
10 checks passed
@netil netil deleted the legend#3663 branch August 13, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants