Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(regions): Enhance regions rendering #3855

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

netil
Copy link
Member

@netil netil commented Jul 25, 2024

Ref

Issue

#3830 #3790

Details

Improve dashed line rendering using css instead path command. Will render same way for nullish value.

Multiple path command Single path command
## Multiple path command
M5,232.59188034188037L95,136.3311965811966M99.1850983903491,139.55194620927864L104.28196148658054,142.77269583736071M109.37882458281199,145.99344546544276L114.47568767904343,149.21419509352484M119.57255077527489,152.4349447216069L124.66941387150631,155.65569434968896M129.76627696773778,158.87644397777103L134.8631400639692,162.0971936058531M139.96000316020064,165.31794323393515L145.0568662564321,168.53869286201723M150.15372935266356,171.75944249009927L155.250592448895,174.98019211818138M160.34745554512645,178.20094174626342L165.44431864135788,181.4216913743455M170.5411817375893,184.64244100242755L175.63804483382077,187.86319063050962M180.73490793005217,191.0839402585917L185.83177102628363,194.30468988667374M183.69607843137257,192.9551282051282L183.69607843137257,192.9551282051282L274,23.083333333333343M274.3757024302515,24.776501143752657L275.44748329187564,26.469668954172M277.5910450151239,29.85600457501063L278.66282587674795,31.549172385429976M280.8063875999962,34.935508006268634L281.8781684616203,36.628675816687924M284.0217301848685,40.01501143752664L285.0935110464926,41.70817924794595M287.2370727697408,45.094514868784586L288.30885363136485,46.787682679203954M290.4524153546131,50.17401830004259L291.52419621623727,51.86718611046193M293.66775793948545,55.253521731300594L294.7395388011096,56.94668954171988M296.88310052435776,60.33302516255856L297.9548813859818,62.02619297297788M300.09844310923006,65.41252859381653L301.1702239708542,67.10569640423589M303.3137856941024,70.49203202507452L304.3855665557265,72.18519983549385M306.52912827897467,75.57153545633248L307.6009091405988,77.2647032667518M309.74447086384697,80.65103888759049L310.8162517254711,82.34420669800981M312.9598134487193,85.73054231884846L314.0315943103434,87.4237101292678M316.17515603359163,90.81004575010644L317.24693689521575,92.50321356052578M319.39049861846394,95.88954918136443L320.462279480088,97.58271699178376M322.60584120333624,100.96905261262242L323.67762206496036,102.66222042304173M325.82118378820854,106.04855604388037L326.8929646498326,107.74172385429969M329.03652637308085,111.12805947513836L330.10830723470497,112.82122728555771M332.25186895795315,116.20756290639633L333.32364981957727,117.90073071681566M335.46721154282545,121.28706633765431L336.5389924044496,122.98023414807365M338.68255412769776,126.36656976891229L339.7543349893219,128.05973757933162M341.8978967125701,131.44607320017028L342.96967757419424,133.1392410105896M345.1132392974424,136.52557663142824L346.1850201590665,138.21874444184758M348.32858188231467,141.60508006268623L349.4003627439388,143.29824787310557M351.543924467187,146.6845834939442L352.6157053288111,148.3777513043635M354.75926705205933,151.76408692520218L355.83104791368345,153.4572547356215M357.9746096369316,156.8435903564601L359.04639049855575,158.53675816687948M361.18995222180394,161.92309378771813L362.26173308342806,163.61626159813744M362.9117647058824,164.6431623931624L362.9117647058824,164.6431623931624M364.59721655730294,163.57811153322723L366.28266840872357,162.51306067329205M369.6535721115648,160.38295895342168L371.33902396298544,159.3179080934865M374.7099276658266,157.18780637361616L376.3953795172473,156.122755513681M379.7662832200885,153.99265379381063L381.45173507150906,152.92760293387545M384.82263877435037,150.7975012140051L386.50809062577093,149.73245035406993M389.8789943286122,147.60234863419956L391.5644461800328,146.53729777426437M394.935349882874,144.407196054394L396.6208017342947,143.34214519445888M399.99170543713586,141.21204347458848L401.67715728855654,140.14699261465333M405.04806099139785,138.01689089478296L406.73351284281836,136.95184003484778M410.10441654565955,134.82173831497744L411.7898683970802,133.75668745504225M415.16077209992136,131.6265857351719L416.84622395134204,130.5615348752367M420.21712765418323,128.43143315536636L421.9025795056039,127.3663822954312M425.2734832084451,125.23628057556083L426.9589350598657,124.17122971562564M430.3298387627069,122.04112799575532L432.0152906141275,120.97607713582012M435.3861943169688,118.8459754159498L437.07164616838935,117.78092455601458M440.44254987123065,115.65082283614423L442.1280017226512,114.58577197620906M445.4989054254925,112.4556702563387L447.18435727691303,111.39061939640354M450.5552609797542,109.26051767653317L452.24071283117496,108.19546681659801M452.5196078431373,108.01923076923076L452.5196078431373,108.01923076923076

## Single path command
M4,232.59188034188037L71,136.3311965811966L139,192.9551282051282L206,23.083333333333343L274,164.6431623931624L341,108.01923076923076

Region with zoom interaction

0a710ba9-9023-1fb8-8190-e346363f7a0e

Profile

Before After

Task duration:

  • 84ms → 5ms 94%

Improve dashed line rendering using css instead path command.
Will render same way for nullish value.

Ref naver#3830 naver#3790
@netil netil added the feature label Jul 25, 2024
@netil netil self-assigned this Jul 25, 2024
@netil netil merged commit 567b323 into naver:master Jul 25, 2024
6 checks passed
@coveralls
Copy link

Coverage Status

coverage: 93.788% (+0.02%) from 93.769%
when pulling 0433b1c on netil:dashedArray#3830
into 5071a47 on naver:master.

@netil netil deleted the dashedArray#3830 branch September 4, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants