Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(regions): Fix applying regions class #3613

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

netil
Copy link
Member

@netil netil commented Jan 23, 2024

Issue

#3611

Details

update ".bb-region rect" rule to not interfere applying regions.class rule

/* before 3.10 */
.bb-region {
	fill: steelblue;
	fill-opacity: .1;
}

/* 
3.10+
previous css rule updated as below, because "fill-opacity" property is affect all descendant elements(like text).
*/
.bb-region {
	rect {
		fill: steelblue;
		fill-opacity: .1;
	}
}

will be updated as

.bb-region {
       fill: steelblue;

       /* it still remains possibility to not take effect, when regions.class='some' contains fill-opacity property */
       /* in that case, needs consider specifity ex.: .some rect { fill:red; fill-opacity: 0.5 } */
	rect {
		fill-opacity: .1;
	}
}

update ".bb-region rect" rule to not interfere applying
regions.class rule

Ref naver#3611
@coveralls
Copy link

Coverage Status

coverage: 94.399%. remained the same
when pulling 8065f97 on netil:region#3611
into c277201 on naver:master.

@netil netil merged commit 7e4fa71 into naver:master Jan 23, 2024
10 checks passed
@netil netil deleted the region#3611 branch January 23, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants