Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gauge): Intent to ship gauge.enforceMinMax #3605

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

netil
Copy link
Member

@netil netil commented Jan 22, 2024

Issue

#2125

Details

Implement enforceMinMax option, which will make data to be displayed in a range of min/max value even value is out of range

gauge: {
  // enforce min/max value.
  // when given value < min, will render as empty value.
  // when value > max, will render to given max value not surpassing it.
  enforceMinMax: true,
  min: 50,  // when given value is 30, gauge will render as empty value.
  max: 100. // when given value is `120`, gauge will render till 100, not surpassing max value.
}

Example of gauge.enforceMinMax=true:

when value=30, gauge.min=50 when value=120, gauge.max=100
image image
not reached min value, so do not draw surpassing max value, so render till max value

Implement enforceMinMax option, which will make data to be
displayed in a range of min/max value even value is out of range

Ref naver#2125
@netil netil added the feature label Jan 22, 2024
@netil netil self-assigned this Jan 22, 2024
@coveralls
Copy link

Coverage Status

coverage: 94.399% (+0.01%) from 94.385%
when pulling 34d0903 on netil:gauge#2125
into 8bfc08b on naver:master.

@netil netil merged commit c277201 into naver:master Jan 22, 2024
10 checks passed
@netil netil deleted the gauge#2125 branch January 22, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants