Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump actions/checkout from 3 to 4 #3397

Closed
wants to merge 41 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
b4e3bc2
feat(regions): Intent to ship regions.label
netil Aug 7, 2023
b7ba810
refactor(grid): Refactor grid update (#3330)
netil Aug 8, 2023
32d6d01
test(plugin): boost test coverage (#3333)
netil Aug 10, 2023
8d83d6f
chore(build): Rename plugin packaged file name (#3335)
netil Aug 11, 2023
c37f526
chore(build): fix plugin build configuration
Aug 11, 2023
f4e0a8c
chore(plugin, api): Sanitize for possible security vulnerability (#3336)
netil Aug 14, 2023
21a1ac4
chore(deps-dev): update depedency (#3344)
netil Aug 16, 2023
976f04a
feat(api): Intent to ship subchart method
netil Aug 16, 2023
90338ec
fix(subchart, zoom): Fix returning domain value
netil Aug 18, 2023
962332f
docs(api): Add notes for .axis' methods (#3349)
netil Aug 18, 2023
ef4776a
test(api): Increase test coverage for APIs (#3350)
netil Aug 21, 2023
0b61783
chore(deps-dev): update dependency (#3357)
netil Aug 22, 2023
b897cbb
fix(subchart): Fix handlebar position
netil Aug 22, 2023
6333297
test(interaction): Increase test coverage for interactions (#3360)
netil Aug 22, 2023
c23c62d
test(subchart): add test case for subchart api (#3361)
netil Aug 23, 2023
d2bd8ab
refactor(flow): Remove duplicated condition (#3362)
netil Aug 23, 2023
b254a61
fix(title): fix title text center align
netil Aug 24, 2023
beec1bb
fix(clip): Fix x axis hide on title.bottom
netil Aug 24, 2023
55c17c6
fix(api): Fix to return indexed categories
netil Aug 24, 2023
98e6f8b
fix(tooltip): Fix tootip display on tooltip.init
netil Aug 24, 2023
2de3d19
test(internals): Add tests for internals code (#3373)
netil Aug 25, 2023
ed66543
test: remove .destroy() on tests
Aug 25, 2023
cd9adc4
test(shape): Reinforce test coverage (#3374)
netil Aug 25, 2023
556918a
chore(readme): update coverage status badge image
netil Aug 25, 2023
22a77eb
test(shapes): Add tests for shapes (#3375)
netil Aug 28, 2023
72aabde
test(plugin): Add tests for plugins (#3376)
netil Aug 28, 2023
071ef60
test(module): Add test for module (#3377)
netil Aug 28, 2023
d04173c
chore(deps-dev): update dependencies (#3383)
netil Aug 29, 2023
4d3764d
test(plugin): Reinforce stanford test (#3384)
netil Aug 29, 2023
715c3d4
test(plugin): Add test for stanford & tableview (#3385)
netil Aug 29, 2023
3f891b3
test(module): update test for worker (#3386)
netil Aug 29, 2023
deb4146
chore: Update README.md
netil Aug 29, 2023
17f5058
fix(candlestick): Fix rendering on rotated axis
netil Aug 30, 2023
3fdc518
test(module): Add test for module & category (#3390)
netil Aug 30, 2023
fb7743c
docs(module): remove unnecessary jsdoc param
Aug 30, 2023
17f9f00
test(module): Update test for browser & worker module (#3391)
netil Aug 30, 2023
f7d587d
fix(tooltip): Fix tooltip.format.value call
netil Aug 31, 2023
dc46717
test(tooltip): Add test to check arguments value (#3393)
netil Aug 31, 2023
216da62
fix(bar): Fix stacking bar position on multiple xs
netil Sep 4, 2023
f4ac3f1
fix(shape): Fix circleY() undefined error
netil Sep 4, 2023
68f61fb
chore(deps): bump actions/checkout from 3 to 4
dependabot[bot] Sep 4, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
node-version: [16.x, 17.x, 18.x]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:
if: contains('refs/heads/next refs/heads/latest', github.ref)
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.ref }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ THE SOFTWARE.
[badge-download]: https://img.shields.io/npm/dm/billboard.js.svg?style=flat
[badge-jsDelivr]: https://data.jsdelivr.com/v1/package/npm/billboard.js/badge?style=rounded
[badge-ci-status]: https://github.com/naver/billboard.js/workflows/CI/badge.svg
[badge-coverage]: https://coveralls.io/repos/github/naver/billboard.js/badge.svg
[badge-coverage]: https://coveralls.io/repos/github/naver/billboard.js/badge.svg?branch=master&v1
[badge-snyk]: https://snyk.io/test/github/naver/billboard.js/badge.svg?targetFile=package.json
[badge-gzip-size]: https://img.badgesize.io/https://unpkg.com/billboard.js/dist/billboard.min.js?compression=gzip
[badge-latest]: https://img.shields.io/npm/v/billboard.js/latest.svg
Expand All @@ -298,7 +298,7 @@ THE SOFTWARE.
[link-download]: https://npm-stat.com/charts.html?package=billboard.js&from=2017-06-08
[link-jsDelivr]: https://www.jsdelivr.com/package/npm/billboard.js
[link-version]: https://www.npmjs.com/package/billboard.js
[link-coverage]: https://coveralls.io/github/naver/billboard.js
[link-coverage]: https://coveralls.io/github/naver/billboard.js?branch=master
[link-snyk]: https://snyk.io/test/github/naver/billboard.js?targetFile=package.json
[link-gzip-size]: https://unpkg.com/billboard.js/dist/billboard.min.js
[link-semantic-release]: https://github.com/semantic-release/semantic-release
Expand Down
10 changes: 4 additions & 6 deletions babel.config.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module.exports = function(api) {
const presets = [
"@babel/typescript",
[
"@babel/env", {
"@babel/preset-env", {
"targets": {
"browsers": [
"last 2 versions",
Expand All @@ -14,17 +14,15 @@ module.exports = function(api) {
},
"modules": false,
"loose": true,
"useBuiltIns": false
"useBuiltIns": false,
exclude: ["@babel/plugin-transform-block-scoping"]
}
]
];

const plugins = [
["@babel/plugin-transform-runtime"],
[
"@babel/plugin-transform-runtime", {
"useESModules": true
}
], [
"@babel/plugin-proposal-class-properties", {
"loose": true
}
Expand Down
29 changes: 17 additions & 12 deletions config/webpack/plugin.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -40,25 +40,18 @@ const config = {
};

module.exports = (common, env) => {
const MODE = env?.MODE;
const mode = env?.MODE;

if (env && MODE === "min") {
config.output.filename = config.output.filename.replace(".js", ".min.js");

config.optimization = {
usedExports: true,
minimize: true,
minimizer: [new TerserPlugin(terserConfig)]
};
} else if (env && MODE === "pkgd") {
if (env && /^pkgd/.test(mode)) {
delete common.externals;

config.output.path = `${distPath}/pkgd`;

for (const key in config.entry) {
config.entry[key] = ["core-js/stable", config.entry[key]];
config.entry[`${key}.pkgd`] = ["core-js/stable", config.entry[key]];
delete config.entry[key];
}
} else {
} else if (!mode) {
config.plugins.push(new CleanWebpackPlugin({
cleanOnceBeforeBuildPatterns: [distPath],
verbose: true,
Expand All @@ -67,6 +60,18 @@ module.exports = (common, env) => {
}));
}

// minify for plugin & plugin pkgd
if (/min$/.test(mode)) {
config.mode = "production";
config.output.filename = config.output.filename.replace(".js", ".min.js");

config.optimization = {
usedExports: true,
minimize: true,
minimizer: [new TerserPlugin(terserConfig)]
};
}

return mergeWithCustomize({
customizeObject: customizeObject({
entry: "replace",
Expand Down
4 changes: 2 additions & 2 deletions demo/chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ var billboardDemo = {
plugins += "new bb.plugin."+ key +"({ // for ESM specify as: new "+ key +"()";
plugins += JSON.stringify(p[key], function(k, v) {
return typeof v === "function" ? v.toString() : v;
}, 5).replace(/\\n/g, "\n").replace(/}$/, " }").replace(/{/, "");
}, 5).replace(/\\n/g, "\n").replace(/}$/g, " }").replace(/{/g, "");
plugins += "),";
})
});
Expand All @@ -379,7 +379,7 @@ var billboardDemo = {
.replace(/(\"|\d),/g, "$1, ");

return k === "json" ?
str.replace(/{/, "{\r\n\t").replace(/}/, "\r\n }") : str;
str.replace(/{/g, "{\r\n\t").replace(/}/g, "\r\n }") : str;
} else if (k === "_plugins") {
return [self.getPluginsCodeStr(v)];
}
Expand Down
55 changes: 55 additions & 0 deletions demo/demo.js
Original file line number Diff line number Diff line change
Expand Up @@ -3993,6 +3993,61 @@ d3.select(".chart_area")
]
}
},
RegionLabel: {
options: {
data: {
columns: [
["data1", 30, 200, 100, 400, 150, 250],
["data2", 100, 150, 130, 200, 220, 190],
],
axes: {
data2: "y2",
},
type: "line",
colors: {
data1: "#ff0000"
}
},
axis: {
y2: {
show: true
}
},
regions: [
{
axis: "x",
start: 1,
end: 2,
class: "regions_class1",
label: {
text: "Regions 1",
color: "red"
}
},
{
axis: "y",
start: 100,
end: 300,
class: "regions_class2",
label: {
text: "Regions 2",
x: 50,
color: "blue"
}
},
{
axis: "y2",
start: 200,
end: 220,
class: "regions_class3",
label: {
text: "Regions 3",
y: 10
}
}
]
}
},
RegionWithTimeseries: {
options: {
data: {
Expand Down
18 changes: 17 additions & 1 deletion karma.conf.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,28 @@ module.exports = function(config) {
target: ["web", "es5"],
module: {
rules: [
{
test: require.resolve("./src/module/browser.ts"),
loader: "exports-loader",
options: {
type: "module",
exports: ["getGlobal", "getFallback"]
}
},
{
test: require.resolve("./src/module/worker.ts"),
loader: "exports-loader",
options: {
type: "module",
exports: "getWorker"
}
},
{
test: /(\.[jt]s)$/,
loader: "babel-loader",
exclude: {
and: [/node_modules/],
not: [/(d3\-.*)$/]
not: [/(d3\-.*)$/, /internmap/]
}
}
]
Expand Down
52 changes: 26 additions & 26 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"build:theme": "cross-env NODE_ENV=theme webpack",
"build:production:analyzer": "cross-env ANALYZER=true npm run build:production",
"build:packaged:analyzer": "cross-env ANALYZER=true npm run build:packaged",
"build:plugin": "cross-env NODE_ENV=plugin webpack && cross-env NODE_ENV=plugin MODE=min webpack && cross-env NODE_ENV=plugin MODE=pkgd webpack",
"build:plugin": "cross-env NODE_ENV=plugin webpack && cross-env NODE_ENV=plugin MODE=min webpack && cross-env NODE_ENV=plugin MODE=pkgd webpack && cross-env NODE_ENV=plugin MODE=pkgd-min webpack",
"build:plugin:types": "node ./config/type.d-plugin.js",
"release": "semantic-release",
"lint": "npm run lint:types && eslint src --ext .ts",
Expand Down Expand Up @@ -85,8 +85,8 @@
"license": "MIT",
"readmeFilename": "README.md",
"dependencies": {
"@types/d3-selection": "^3.0.5",
"@types/d3-transition": "^3.0.3",
"@types/d3-selection": "^3.0.6",
"@types/d3-transition": "^3.0.4",
"d3-axis": "^3.0.0",
"d3-brush": "^3.0.0",
"d3-drag": "^3.0.0",
Expand All @@ -102,32 +102,32 @@
"d3-zoom": "^3.0.0"
},
"devDependencies": {
"@babel/core": "^7.22.10",
"@babel/eslint-parser": "^7.22.10",
"@babel/core": "^7.22.11",
"@babel/eslint-parser": "^7.22.11",
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/plugin-proposal-object-rest-spread": "^7.20.7",
"@babel/plugin-transform-runtime": "^7.22.10",
"@babel/preset-env": "^7.22.10",
"@babel/preset-typescript": "^7.22.5",
"@babel/runtime": "^7.22.10",
"@commitlint/cli": "17.6.7",
"@commitlint/config-conventional": "^17.6.7",
"@babel/preset-typescript": "^7.22.11",
"@babel/runtime": "^7.22.11",
"@commitlint/cli": "17.7.1",
"@commitlint/config-conventional": "^17.7.0",
"@rollup/plugin-babel": "^6.0.3",
"@rollup/plugin-node-resolve": "^15.0.2",
"@rollup/plugin-node-resolve": "^15.2.1",
"@rollup/plugin-replace": "^5.0.2",
"@rollup/plugin-typescript": "^11.1.2",
"@rollup/plugin-typescript": "^11.1.3",
"@semantic-release/changelog": "^6.0.3",
"@semantic-release/commit-analyzer": "^10.0.1",
"@semantic-release/commit-analyzer": "^10.0.4",
"@semantic-release/exec": "^6.0.3",
"@semantic-release/git": "^10.0.1",
"@semantic-release/npm": "^10.0.4",
"@semantic-release/release-notes-generator": "^11.0.4",
"@semantic-release/npm": "^10.0.5",
"@semantic-release/release-notes-generator": "^11.0.7",
"@types/chai": "^4.3.5",
"@types/d3": "^7.4.0",
"@types/mocha": "^10.0.1",
"@types/sinon": "^10.0.16",
"@typescript-eslint/eslint-plugin": "^6.3.0",
"@typescript-eslint/parser": "^6.3.0",
"@typescript-eslint/eslint-plugin": "^6.5.0",
"@typescript-eslint/parser": "^6.5.0",
"babel-helper-modules": "^6.0.0",
"babel-loader": "^9.1.3",
"babel-plugin-add-module-exports": "^1.0.4",
Expand All @@ -140,10 +140,10 @@
"babel-plugin-transform-merge-sibling-variables": "^6.9.5",
"babel-plugin-transform-minify-booleans": "^6.9.4",
"better-docs": "^2.7.2",
"chai": "^4.3.7",
"chai": "^4.3.8",
"clean-webpack-plugin": "^4.0.0",
"cloc": "^2.11.0",
"core-js": "^3.32.0",
"core-js": "^3.32.1",
"coveralls": "^3.1.1",
"cross-env": "^7.0.3",
"css-loader": "^6.8.1",
Expand All @@ -154,10 +154,10 @@
"d3-polygon": "^3.0.1",
"docdash": "^2.0.1",
"dtslint": "^4.2.1",
"eslint": "^8.46.0",
"eslint": "^8.48.0",
"eslint-config-naver": "^2.1.0",
"eslint-plugin-import": "^2.28.0",
"eslint-plugin-jsdoc": "^46.4.6",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-jsdoc": "^46.5.0",
"eslint-webpack-plugin": "^4.0.1",
"exports-loader": "^4.0.0",
"hammer-simulator": "0.0.1",
Expand All @@ -175,24 +175,24 @@
"karma-sinon": "^1.0.5",
"karma-sourcemap-loader": "^0.4.0",
"karma-webpack": "^5.0.0",
"lint-staged": "^13.2.3",
"lint-staged": "^14.0.1",
"lite-fixture": "^1.0.2",
"mini-css-extract-plugin": "^2.7.6",
"mocha": "^10.2.0",
"node-sass": "^9.0.0",
"regenerator-runtime": "^0.14.0",
"rollup": "^3.27.2",
"rollup": "^3.28.1",
"rollup-plugin-delete": "^2.0.0",
"sass-loader": "^13.3.2",
"semantic-release": "^21.0.7",
"semantic-release": "^21.1.1",
"simulant": "^0.2.2",
"sinon": "^15.2.0",
"string-replace-loader": "^3.1.0",
"style-loader": "^3.3.3",
"taffydb": "^2.7.3",
"terser-webpack-plugin": "^5.3.9",
"tslib": "^2.6.1",
"typescript": "5.1.6",
"tslib": "^2.6.2",
"typescript": "5.2.2",
"webpack": "^5.88.2",
"webpack-bundle-analyzer": "^4.9.0",
"webpack-clean": "^1.2.5",
Expand Down
4 changes: 4 additions & 0 deletions src/Chart/api/axis.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ function getMinMax($$, type: "min" | "max"): {x: number, y: number, y2: number}
const axis = {
/**
* Get and set axis labels.
* - **NOTE:** Only applicable for chart types which has x and y axes.
* @function axis․labels
* @instance
* @memberof Chart
Expand Down Expand Up @@ -126,6 +127,7 @@ const axis = {

/**
* Get and set axis min value.
* - **NOTE:** Only applicable for chart types which has x and y axes.
* @function axis․min
* @instance
* @memberof Chart
Expand Down Expand Up @@ -163,6 +165,7 @@ const axis = {

/**
* Get and set axis max value.
* - **NOTE:** Only applicable for chart types which has x and y axes.
* @function axis․max
* @instance
* @memberof Chart
Expand Down Expand Up @@ -200,6 +203,7 @@ const axis = {

/**
* Get and set axis min and max value.
* - **NOTE:** Only applicable for chart types which has x and y axes.
* @function axis․range
* @instance
* @memberof Chart
Expand Down
Loading