Enhancements/redesign #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class currently contains authentication functionality only.
…tor into an enum class.
…me mapping and helper functions.
…aking b2c requests to Daraja.
Removed previously implemented functions and imports and replaced with current implementation that reflects the issues raised in issue #1.
This is not to denote the readiness of the app for release, but to show a complete overhaul of the app.
Refactored the originator conversation id to the child table as it needs to be unique for each request made. Deleted unused client side code for initiating payment from the mpesa b2c payment doctype as the functionality has been moved to the "on submit" document hook.
This is to quickly get a dict representation of json data, excluding a few fields, precluding the need to manually build the payload when needed.
…hod allowing for dynamic building of the payload.
… doctype. Performed some minor refactors on the b2c payment doctype.
…nse to observer classes that handle their logging.
… initiating payment request, the payment request won't be sent to daraja api. Added docstrings to the methods.
…onnectorBaseClass.
…isations on uninstallation.
…t linter, performed imports optimisation
…e Observer.update() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.