Retry wait for stable service in deploy release #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
approved these changes
Oct 1, 2024
bin/deploy-release
Outdated
| @@ -25,6 +25,9 @@ echo "::endgroup::" | |||
| cluster_name=$(terraform -chdir="infra/${app_name}/service" output -raw service_cluster_name) | |||
| service_name=$(terraform -chdir="infra/${app_name}/service" output -raw service_name) | |||
| echo "Wait for service ${service_name} to become stable" | |||
| aws ecs wait services-stable --cluster "${cluster_name}" --services "${service_name}" | |||
| if ! aws ecs wait services-stable --cluster "${cluster_name}" --services "${service_name}"; then | |||
| echo "First attempt to wait for service stability failed, retrying..." | |||
There was a problem hiding this comment.
Nit: grammar a bit awkward, couple of suggestions to keep it simple:
option A: Repeat "Wait for service app-dev to become stable" (aws ecs wait service-stable already has an error message)
option B: Say "Retrying"
doshitan
reviewed
Oct 1, 2024
KevinJBoyer
commented
Oct 1, 2024
KevinJBoyer
commented
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
n/a
Changes
Context for reviewers
Testing
Tested on internal tool (posted in Slack)