Add scheduled jobs #745
Merged
Add scheduled jobs #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
approved these changes
Sep 1, 2024
There was a problem hiding this comment.
After this is merged don't forget to:
- Check that template-only-cd.yml ran ok, if not you'll need to manually push changes to the platform-test* repos for the ones that failed. (Don't forget to update .template-version in the platform-test* repos if you need to do a manual update)
- Uncomment the cron job in platform-test (feel free to make the change directly on main, no need to open a PR)
Comment on lines
8
to
13
| scheduled_jobs = { | ||
| cron = { | ||
| task_command = ["python", "-m", "flask", "--app", "app.py", "cron"] | ||
| schedule_expression = "cron(0 * ? * * *)" | ||
| } | ||
| } |
There was a problem hiding this comment.
For the template we want this commented out since it's just an example, similar to what we did in file_upload_jobs.tf, then after this is merged in template-infra, we want to uncomment this config in platform-test so that we can exercise the functionality.
|
Another way to update platform-test if the template CD doesn't work is to:
|
coilysiren
added a commit
to navapbc/platform-test
that referenced
this pull request
Sep 27, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #525
Changes
Testing
Tested via navapbc/platform-test#130, and triggering a step functions job manually.