Add check infra deploy status workflow #682
Conversation
|
@rocketnova no rush but this should be ready for review now |
|
Now that we checked in the role manager dependencies, we can add the database layer to this check |
Actually I lied, the archive_file data source still produces a new hash every time so it still shows up as a diff. We'd have to source control the archive file itself if we want to keep that :/ |
|
Ok handled it in #695 |
There was a problem hiding this comment.
@lorenyu This looks great. Excellent use of jq.
One change for this PR: I think we should document that jq is a requirement for Github Actions, even if it comes with the default Github Action environment, so that it's not a hidden dependency that breaks someday in the future and becomes really hard to debug.
| function get_app_names() { | ||
| find "infra" -maxdepth 1 -type d -not -name "infra" -not -name "accounts" -not -name "modules" -not -name "networks" -not -name "project-config" -not -name "test" -exec basename {} \; | ||
| } |
There was a problem hiding this comment.
Note for the future: Another reason to nest all apps in an /infra/apps dir.
There was a problem hiding this comment.
Created ticket #699 feel free to add to it
Ticket
Resolves #623
Changes
Context for reviewers
Ok this is finally ready for review
Testing
Developed and tested in platform-test in navapbc/platform-test#117