Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add init healthcheck code #40

Merged
merged 5 commits into from
Jun 11, 2024
Merged

add init healthcheck code #40

merged 5 commits into from
Jun 11, 2024

Conversation

ccheng26
Copy link
Collaborator

@ccheng26 ccheng26 commented Jun 11, 2024 •
edited
Loading

Ticket

Resolves #DST-232

Changes

  • added health check code for get response and logging test

Context for reviewers

Testing

Testing instructions and expected behavior:

  1. pip install -r requirements.txt
  2. run python -m unittest discover

@ccheng26 ccheng26 marked this pull request as ready for review June 11, 2024 17:36
KevinJBoyer
KevinJBoyer approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@KevinJBoyer KevinJBoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one error on a f-string and a couple optional cleanups/nits!

05-assistive-chatbot/chatbot_api.py Outdated Show resolved Hide resolved
05-assistive-chatbot/test/test_chatbot_api.py Outdated Show resolved Hide resolved
05-assistive-chatbot/test/test_chatbot_api.py Outdated Show resolved Hide resolved
@ccheng26 ccheng26 merged commit fb9ce50 into main Jun 11, 2024
1 check passed
@ccheng26 ccheng26 deleted the DST-232-addHealthCheck branch June 11, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinJBoyer KevinJBoyer KevinJBoyer approved these changes

@yoomlam yoomlam Awaiting requested review from yoomlam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccheng26 @KevinJBoyer