feat: Add summarizing and quoting capabilities to 05-assistive-chatbot #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoomlam
commented
May 30, 2024
| from chatbot.ingest.text_splitter import TextSplitter | ||
|
|
||
| logger = logging.getLogger(f"chatbot.{__name__}") | ||
|
|
||
|
|
There was a problem hiding this comment.
moved the following to a reusable vector_db.py so that the same default settings can be used by the chatbot to retrieve from the DB
yoomlam
commented
May 30, 2024
Comment on lines
+153
to
+154
| if quote != card: | ||
| card_to_quotes[card].add(quote) |
There was a problem hiding this comment.
If the quote == card title, then don't use it as a quote b/c the card title will already be shown in the UI and the title/question is not particular helpful as a quote.
yoomlam
commented
May 30, 2024
| ) | ||
|
|
||
|
|
||
| ingest_vectordb_wrapper = LocalLangchainChromaVectorDb() |
There was a problem hiding this comment.
ingest_vectordb_wrapper provides the same default settings for use by ingest-guru-cards.py and the chatbot.
ccheng26
reviewed
Jun 3, 2024
| return { | ||
| "content": "\n".join(resp + dq_resp + cards_resp), | ||
| "elements": [ | ||
| # cl.Text(name="Derived Questions", content="\n".join(dq_resp), display="side"), |
There was a problem hiding this comment.
I'll leave it for now as an example of how to use cl.Text with different display parameters -- it's not intuitive.
ccheng26
reviewed
Jun 3, 2024
| self.vectordb_wrapper = vector_db.ingest_vectordb_wrapper | ||
| self.retrieve_k = int(settings.pop("retrieve_k")) | ||
|
|
||
| # TODO: ingestigate if this should be set to true |
ccheng26
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Partly resolves https://navalabs.atlassian.net/browse/DST-218
Changes
Populate prototype code in
05-assistive-chatbotwith the summarizing and quoting capabilities from02-household-querieschatbot.Update handling
settingsfor LLM clients and did some general refactoring.Context for reviewers
This provides baseline summarizing and quoting capabilities for the prototype.
Testing
Testing instructions and expected behavior:
pip install -r requirements.txt.envrm -rf chroma_db && ./ingest-guru-cards.py*instructmodel for both LLMs):Settings panelby clicking on the icon to the left of the bottom text input field.Chat Mode(synonymous withCHAT_ENGINEfor thecmdline.pyapp) and pickopenai :: gpt-3.5-turbo-instructas thePrimary LLMandLLM Model for summarizer. Adjust the twoTemperature...settings to play with the responses.Confirm