Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HyDE and reranking to evaluation #18

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

KevinJBoyer
Copy link
Collaborator

Ticket

Resolves https://navalabs.atlassian.net/browse/DST-180

Changes

  • Add HyDE and reranking to RAG prototype in eval pipeline

Context for reviewers

@yoomlam yoomlam changed the base branch from main to kb/evals April 19, 2024 13:16
Copy link
Collaborator

@yoomlam yoomlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -30,6 +32,13 @@
Please answer using the following context:
{context}"""

HYDE_PROMPT = """Please write a hypothetical document that would answer the following question about SNAP (food stamps.)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HYDE_PROMPT = """Please write a hypothetical document that would answer the following question about SNAP (food stamps.)
HYDE_PROMPT = """Please write a hypothetical document that would answer the following question about SNAP (food stamps).

@@ -5,6 +5,7 @@
beautifulsoup4
chainlit
chromadb
cohere
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to run pip-compile requirements.in to update requirements.txt

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read this comment, thought "ah right", and then pushed merge 😂 -- I'll update on the base branch now before merging.

@yoomlam
Copy link
Collaborator

yoomlam commented Apr 19, 2024

I changed the base branch so that I only see the changes compared to PR #17, which I approved.

@yoomlam
Copy link
Collaborator

yoomlam commented Apr 19, 2024

Looking forward to discussing the results!

@KevinJBoyer KevinJBoyer merged commit 1badf12 into kb/evals Apr 19, 2024
2 checks passed
@KevinJBoyer KevinJBoyer deleted the kb/hyde-reranking branch April 19, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants