Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip processing on closed result channel, fix panic #215

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

JohnStarich
Copy link
Member

Skip processing on closed result channel, fix panic

case payload, ok := <-resultCh:
if !ok {
return
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me how to introduce a test for this scenario. It does seem like restructuring channels/wait groups/locks may be in order for a more modular and testable execution flow.

@JohnStarich JohnStarich merged commit 634cff6 into master Aug 21, 2024
6 checks passed
@JohnStarich JohnStarich deleted the bugfix/stop-processing-on-closed-results branch August 21, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant