Fix the .list node for the StringArrayEditor
#3866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes the icon buttons on the stringArrayEditor/tagInput `.list` element so that they are inline, given the correct background, and aligned correctly.
|
Does this one conflict with #3894 at all? Do you have a preference of which gets merged first? |
I would just go with 3894, and this can be closed, reopening if necessary. The tagInput PRs have a few more in the pipe, and i can't remember right now which bits of styling happen where but I'm sure I didn't take anything from this PR and reuse it (intentionally). |
|
Then closing this for now, as #3894 should fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the icon buttons on the stringArrayEditor/tagInput
.listelement so that they are inline, given the correct background, and aligned correctly. Restores pink validation styling.Description
Here it is broken, on Live:
Here it is fixed:
Related Issues or Discussions
QA Instructions, Screenshots, Recordings
Try using the string array editor (aka "tags" and "authors" inputs) in the Properties Editor. The three states should all display properly (non-editing 'badge', editing badge, and empty badge/input).
Add'l comments
Likely the metadataEditor.less file could be overhauled more completely, but I'm just focused on fixing this one thing. In my TagInput PR there are significant changes to the .less file so I don't want to muck about too much in there right now if i don't have to.