Vitreum-less build scripts #3566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Ambatte
added
P3 - low priority
|
I believe this is a change important enough that we should roll it on its own, to make sure we know where any error comes from. |
G-Ambatte
added
🔍 R0 - Needs first review 👀
|
Interesting. Do you think this can turn into using webpack or something instead of Browserify in a future PR? |
That's my hope - once we can see what Browserify is actually doing, then we can learn how to transition to a new bundler using the existing Browserify guides... because there's no such thing for Vitreum. |
|
Right, cannot review this if it has conflicts and deployment doesn't work |
5e-Cleric
added
🔍 R_ - Not ready for review 🕑
and removed
🔍 R0 - Needs first review 👀
|
I've taken a stab at bringing this up to current this morning, there are multiple issues with the change from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to resolve #3480.
The initial step has been to extract all the useful parts of Vitreum to the main Homebrewery project, so those build tools are not obfuscated in an additional project.