-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add administrative brew locking function #3327
Add administrative brew locking function #3327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, and I would be ok merging this to form a basis for the next steps, since it shouldn't break anything. Do you want me to merge it now or keep tinkering on it?
I'll keep tinkering for now, I've used |
Not sure if this is useful, but there is a |
I haven’t taken a strong look at this beyond just get comments/screenshots here, so pardon if I missed it: i think this needs two things: a list of possible reasons the brew is locked (just a static thing, not anything actually related to a specific brew), and a path to contacting “administrators” like a link to the Reddit mod mail or whatever. Right now it just looks overly harsh, with no indication of what the issue could be and no further help to get it fixed. Part of this is styling (big red letters) and part of it is content. Further, it might just be best to say “unavailable” rather than locked, or even just use the same error page as the other “no brew” error. I’m not sure we need to tell all viewers that an author is getting DMCA’d (when we aren’t the ones really arbitrating/deciding that) |
Merging this as a first step toward #3326 . Thanks @G-Ambatte ! |
This PR is work towards #3326.
This PR adds a check to the
getBrew
function that throws an error if the brew stub has alock
object with astate
property set to 1 or 2.State 1: locked, inaccessible.
State 2: locked, only accessible via Edit page.
The intended purpose of this function is to allow administrators to prevent access to brews that have identified issues - for example, DMCA take down requests.