Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Underline Token #3185

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

dbolack-ab
Copy link
Collaborator

Override the poorly chose underscore as emphasis to it's one true purpose! Underline!

Seriously though. Changes Thing to be an underlined Thing. Regex may need tightening up.

@calculuschild calculuschild added blocked Waiting on a dependency, other feature, etc., first 🚀 V4 Wait for V4 labels Dec 14, 2023
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3185 December 14, 2023 22:31 Inactive
@5e-Cleric 5e-Cleric added this to the Homebrewery v4 milestone Jan 16, 2024
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3185 January 17, 2024 17:22 Inactive
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3185 January 18, 2024 20:04 Inactive
@dbolack-ab dbolack-ab self-assigned this Jan 19, 2024
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3185 May 12, 2024 15:41 Inactive
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3185 June 2, 2024 17:36 Inactive
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3185 August 1, 2024 16:19 Inactive
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3185 August 2, 2024 20:53 Inactive
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3185 August 13, 2024 17:17 Inactive
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3185 August 29, 2024 02:13 Inactive
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3185 August 31, 2024 16:09 Inactive
@5e-Cleric
Copy link
Member

Seems to be working just fine.

  • syntax creates an <u></u> element around the text
  • injected styles work on it

doesn't seem to be breaking anything

@5e-Cleric 5e-Cleric self-requested a review September 19, 2024 05:55
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3185 October 7, 2024 19:34 Inactive
@5e-Cleric 5e-Cleric removed their request for review October 30, 2024 22:51
@dbolack-ab dbolack-ab added the 🔍 R0 - Needs first review 👀 PR ready but has not been reviewed label Nov 12, 2024
@5e-Cleric
Copy link
Member

Because of the minimalistic nature of this PR, i think it should be kept open or as draft as is until we can merge (v4). With as little maintenance as possible. I wish we could merge it now.

@5e-Cleric 5e-Cleric added 🔍 R4 - Reviewed - Fixed! Awaiting final review⭐ PR review comments addressed and removed 🔍 R0 - Needs first review 👀 PR ready but has not been reviewed labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting on a dependency, other feature, etc., first 🔍 R4 - Reviewed - Fixed! Awaiting final review⭐ PR review comments addressed 🚀 V4 Wait for V4
Projects
Status: Not planned
Development

Successfully merging this pull request may close these issues.

4 participants