-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Underline Token #3185
Open
dbolack-ab
wants to merge
20
commits into
naturalcrit:master
Choose a base branch
from
dbolacksn:underline
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create Underline Token #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calculuschild
added
blocked
Waiting on a dependency, other feature, etc., first
🚀 V4
Wait for V4
labels
Dec 14, 2023
Seems to be working just fine.
doesn't seem to be breaking anything |
dbolack-ab
added
the
🔍 R0 - Needs first review 👀
PR ready but has not been reviewed
label
Nov 12, 2024
Because of the minimalistic nature of this PR, i think it should be kept open or as draft as is until we can merge (v4). With as little maintenance as possible. I wish we could merge it now. |
5e-Cleric
added
🔍 R4 - Reviewed - Fixed! Awaiting final review⭐
PR review comments addressed
and removed
🔍 R0 - Needs first review 👀
PR ready but has not been reviewed
labels
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
Waiting on a dependency, other feature, etc., first
🔍 R4 - Reviewed - Fixed! Awaiting final review⭐
PR review comments addressed
🚀 V4
Wait for V4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override the poorly chose underscore as emphasis to it's one true purpose! Underline!
Seriously though. Changes Thing to be an underlined Thing. Regex may need tightening up.