-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill out missing style snippets #1096
Comments
The "Page Number" snippet contains both a page number component and a 'footer' component, and I think they should be separated....or, the footer component be added to the "Auto Incrementing Page Number" snippet as well...it's weird that the footer is in one, but not the other. |
I don't mind separating them. That makes sense to me. |
User u/Kaiburr_Kath-Hound on Reddit (with help from others) has completed several of these and notified me that he would like to contribute them as official snippets. May need slight tweaks but 95% of the work is done: https://www.reddit.com/r/homebrewery/comments/qubn28/phbstyle_including_title_page_credits_page/ |
No longer blocked by #1093 as on 12 Sep 2021. |
Update on this: Include snippets for common missing PHB items
*: related PR I consider as Done when i have a working demo. Most are already done in Kaiburr's Player's Handbook Template if you want to add a snippet, comment here. |
Closing, as track of snippets will now be kept in #3236 |
Once the new rendering pipeline is in place, we can start inserting more requested code snippets and styling features that users have created or requested for a long time. Part of the reason these have not been added until now, is the over-dependence on random markdown combinations to create textboxes, which leads to lots of conflicting styling issues in the CSS. Further, the use of invalid markdown due to an outdated markdown parser makes these conflicts even more common.
Blocked by #1093. Once that is complete, more of these tasks can be finished out.
This issue will collect the sub-tasks and related issues.
Tasks
Clean up existing styling and snippets
Include snippets for common missing PHB items
(collect from issues, a lot of these are already figured out)
Include snippets for user convenience
(collect from issues)
Correct other existing style bugs
The text was updated successfully, but these errors were encountered: