Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dsy 4005 add prop color in Button component #1805

Merged
merged 40 commits into from
Jan 10, 2024
Merged

Dsy 4005 add prop color in Button component #1805

merged 40 commits into from
Jan 10, 2024

Conversation

vagnerbarbosant
Copy link
Collaborator

Description

Dsy 4005 add prop color in Button component

Type of change

  • feat: new feature for the user, not a new feature for build script
  • fix: bug fix for the user, not a fix to a build script
  • docs: changes to the documentation
  • style: formatting, missing semi colons, etc; no production code change
  • refactor: refactoring production code, eg. renaming a variable
  • test: adding missing tests, refactoring tests; no production code change
  • chore: updating grunt tasks etc; no production code change

Quality Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors;
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My commits follow the Conventional Commits Guidelines;

affects: @naturacosmeticos/natds-react
DSY-4005
affects: @naturacosmeticos/natds-react
DSY-4005
@vagnerbarbosant vagnerbarbosant requested a review from a team as a code owner November 17, 2023 03:19
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72c003f) 99.14% compared to head (114a4e8) 99.14%.
Report is 1 commits behind head on main.

❗ Current head 114a4e8 differs from pull request most recent head 120d197. Consider uploading reports for the commit 120d197 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1805   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         194      194           
  Lines        1283     1284    +1     
  Branches      390      391    +1     
=======================================
+ Hits         1272     1273    +1     
  Misses         11       11           
Files Coverage Δ
packages/react/src/components/Button/Button.tsx 100.00% <100.00%> (ø)

vagnerbarbosant and others added 20 commits November 23, 2023 09:09
affects: @naturacosmeticos/natds-react
DSY-4005
affects: @naturacosmeticos/natds-react
DSY-4005
affects: @naturacosmeticos/natds-react
DSY-4005
affects: @naturacosmeticos/natds-react
DSY-4005
affects: @naturacosmeticos/natds-react
DSY-4005
affects: @naturacosmeticos/natds-react
DSY-4005
affects: @naturacosmeticos/natds-react
DSY-4005
affects: @naturacosmeticos/natds-react
DSY-4005
affects: @naturacosmeticos/natds-react
DSY-4005
@vagnerbarbosant vagnerbarbosant merged commit d1bc90f into main Jan 10, 2024
4 checks passed
@vagnerbarbosant vagnerbarbosant deleted the DSY-4005 branch January 10, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants