Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace flush interval with a fused sleep #934

Closed
wants to merge 1 commit into from
Closed

Replace flush interval with a fused sleep #934

wants to merge 1 commit into from

Conversation

caspervonb
Copy link
Collaborator

Alternative to #933

@caspervonb
Copy link
Collaborator Author

Marginally better than #933, still can't reach in and reset the sleep however.

@paolobarbolini
Copy link
Contributor

paolobarbolini commented Apr 25, 2023 •
edited
Loading

Looks better than the previous version. I guess the ultimate optimization will be to remove the timer completely one day.

If #935 gets merged the current implementation will break because you're using futures' version of things.

@caspervonb caspervonb force-pushed the replace-flush-interval-with-fused-sleep branch from d4187b1 to 66806eb Compare July 14, 2023 10:39
@caspervonb
Copy link
Collaborator Author

Closing in favor of #1070

@caspervonb caspervonb closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caspervonb @paolobarbolini