Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream_by_subject #1287

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Add stream_by_subject #1287

merged 4 commits into from
Jul 26, 2024

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jul 25, 2024

Being able to check if stream exist looking it up by subject was mentioned few times, recently here: vectordotdev/vector#20834

Signed-off-by: Tomasz Pietrek [email protected]

Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Version 0.3.24 was causing error on minimal versions check:

```
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.24/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++
```

Signed-off-by: Tomasz Pietrek <[email protected]>
@Jarema Jarema merged commit 36ae95f into main Jul 26, 2024
12 checks passed
@Jarema Jarema deleted the add-stream-by-name branch July 26, 2024 15:46
This was referenced Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants