Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concrete errors to Object Store #1015

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jul 10, 2023

Signed-off-by: Tomasz Pietrek [email protected]

@Jarema Jarema requested a review from caspervonb July 10, 2023 06:59
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming nit

@@ -457,7 +522,7 @@ pub struct List<'a> {
}

impl Stream for List<'_> {
type Item = Result<ObjectInfo, Error>;
type Item = Result<ObjectInfo, ListerError>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type Item = Result<ObjectInfo, ListerError>;
type Item = Result<ObjectInfo, ListError>;

}

#[derive(Debug)]
pub struct WatcherError {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub struct WatcherError {
pub struct WatchError {

Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jarema Jarema merged commit f0faf11 into main Jul 10, 2023
13 checks passed
@Jarema Jarema deleted the jarema-object-store-concrete-errors branch July 10, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants