Export LameDuckShutdown so that it is accessible when embedding NATS
#5660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
requested changes
Jul 16, 2024
neilalexander
force-pushed
the
neil/ldmapi
branch
from
954a34e
to
3a93a5d
Compare
wallyqs
reviewed
Jul 16, 2024
neilalexander
force-pushed
the
neil/ldmapi
branch
from
3a93a5d
to
fa89d75
Compare
…when embedding NATS Otherwise this function isn't available when embedding the NATS Server, where using `SIGUSR2` likely isn't appropriate. Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/ldmapi
branch
from
fa89d75
to
11c5ba2
Compare
neilalexander
changed the title
lameDuckMode to LameDuckShutdown so that it is accessible when embedding NATSLameDuckShutdown so that it is accessible when embedding NATS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise this function isn't available when embedding the NATS Server, where using
SIGUSR2likely isn't appropriate.Signed-off-by: Neil Twigg [email protected]