Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nats-box deployment so nats user can be used #882

Closed
wants to merge 1 commit into from

Conversation

ddanat-smm
Copy link

When installing nats-box with the helm chart the current implementation saves the current directory as the "work_dir". In the Dockerfile that is "/root". Even though the user "nats" with uid 1000 is created in the Dockerfile, if the current deployment (which just does a sleep infinity) starts as uid 1000, work_dir gets saved as "/root" and when the cd $work_dir comes, the container crashes. This fixes that issue.

Sorry if this doesn't quite adhere to your PR guidelines - this is just a quick and dirty commit

@caleblloyd
Copy link
Contributor

I think a better fix may be changing the exec to:

exec /entrypoint.sh "$@"

Because the nats-box entrypoint already handles this logic

That will also not break anyone who is using workingDir

@caleblloyd
Copy link
Contributor

Opened #883 with the change, closing this one

@caleblloyd caleblloyd closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants