feat: shared view pools [wip] #68
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigor789
commented
Aug 6, 2023
| } | ||
| const isNonSync = holder['defaultItemView'] === true; | ||
| const view = isNonSync ? (holder.view as ContentView).content : holder.view; | ||
| this.notifyForItemAtIndex(CollectionViewBase.itemDisposingEvent, view, holder.getAdapterPosition(), view.bindingContext, holder); |
There was a problem hiding this comment.
This should likely be fired on the CollectionView instances as well?
rigor789
commented
Aug 6, 2023
| } | ||
| const isNonSync = holder['defaultItemView'] === true; | ||
| const view = isNonSync ? (holder.view as ContentView).content : holder.view; | ||
| this.notifyForItemAtIndex(CollectionViewBase.itemRecyclingEvent, view, holder.getAdapterPosition(), view.bindingContext, holder); |
There was a problem hiding this comment.
This should also likely be fired for all CollectionView instances as well (perhaps this.notifyForItemAtIndex would just notify self + all attached collectionView instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft/wip branch of implementing shared view pools.
Shared pools will allow defining the item templates in a separate view/element, and reuse them for multiple CollectionViews. This is especially useful for nested CollectionViews, where we may have multiple CollectionViews rendering the same templates.
For simplicity, pool related logic has been moved to a new
SharedCollectionViewPoolclass, so even if the view doesn't share the pool, it will still create one automatically and use that (rather than duplicating the logic in both classes).todos:
SharedCollectionViewPool