Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add highlight row events and improved stability #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add highlight row events and improved stability #48

wants to merge 1 commit into from

Conversation

NathanWalker
Copy link
Member

@NathanWalker NathanWalker commented Jan 4, 2023 •
edited
Loading

  • added itemHighlight and itemHighlightEnd events
  • enabled displayItem event for custom show animation handling
  • improved strong type checking and reduced scoped variable usage
  • strengthen async conditions of null/undefined
  • uses deref for iOS weakref since supported there, keep get on android for now

@MrSnoozles
Copy link
Contributor

@farfromrefug Is it possible to merge the changes? I implemented the CollectionView on Android. Upon testing on iOS I have regular app crashes that are related to the CollectionView. Would like to see if this PR solves them.

@farfromrefug
Copy link
Member

@MrSnoozles that PR will propably not solve it. And you should report with crash callstack son that we can fiest mâle sur it actually is an issue with collectionview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NathanWalker @MrSnoozles @farfromrefug