Fix Android Platform bootstrap. #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of all, java.io.File.createtempFile() causes "permission denied" error unless it is explicitly passed a path that is known to be writable. http://stackoverflow.com/questions/3660572/android-createtempfile-throws-permission-denied To fix this, we need Android's Context instance, which is expected to be supplied by AndroidSuppport.setApplication() method (which is specific to Android version build). However, this File.createTempFile() is called by Platform, and Platform class is already initialized when AndroidSupport is getting initialized. So, the entire Platform initialization cycle is broken for Android now. To fix this issue, I had to make API breaking change to add another room for Android's Application (Context) outside this Platform loop so that it can be safely initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, java.io.File.createtempFile() causes "permission denied"
error unless it is explicitly passed a path that is known to be writable.
http://stackoverflow.com/questions/3660572/android-createtempfile-throws-permission-denied
To fix this, we need Android's Context instance, which is expected to
be supplied by AndroidSuppport.setApplication() method (which is specific
to Android version build).
However, this File.createTempFile() is called by Platform, and Platform
class is already initialized when AndroidSupport is getting initialized.
So, the entire Platform initialization cycle is broken for Android now.
To fix this issue, I had to make API breaking change to add another
room for Android's Application (Context) outside this Platform loop
so that it can be safely initialized.