Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom file formats (aside from SequenceFileFormat) to pass args #33

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

baconz
Copy link

@baconz baconz commented Jun 24, 2013

I'm working on an AvroFileFormat, and I'd like to be able to pass it args -- this seemed like the least bad way to make it happen. Open to suggestions for other approaches.

@sritchie
Copy link
Collaborator

@sorenmacbeth, all you!

@sorenmacbeth
Copy link
Collaborator

Looks good at first glance to me. I'll give a more thorough going over soon. Thanks!

@cmerrick
Copy link

cmerrick commented Jul 8, 2013

I ran into this same issue when trying to create a custom Avro file format that keeps track of the schema in args. +1 for this!

@kul
Copy link

kul commented Sep 15, 2013

👍 for the well thought change.
@baconz @cmerrick how do you get the arguments inside the serialize and deserialize methods in your implemented PailStructure? I am not able to figure this out.

@stanfea
Copy link

stanfea commented Apr 9, 2015

@baconz Did you get AvroFileFormat working?

I've made a pail structure that serializes and deserializes to from avro but it's stored in a SequenceFile and I'm getting poor performance from the pail tap this way. Thanks

@baconz
Copy link
Author

baconz commented Apr 11, 2015

@steanbacon we never did. More, or less abandoned this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants