-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#910 Fix incorrect product option combinations #922
#910 Fix incorrect product option combinations #922
Conversation
Product Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mochacr0, I have added a few comments. Please take a look.
Thanks!
product/src/main/java/com/yas/product/service/ProductService.java
Outdated
Show resolved
Hide resolved
|
||
setProductBrand(productPostVm.brandId(), mainProduct); | ||
|
||
List<ProductCategory> productCategories = setProductCategories(productPostVm.categoryIds(), mainProduct); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method name setProductCategories
can be misleading because the word set
typically for updating an existing value. We should change it to getProductCategories
or something else.
This comment applies to other methods as well
product/src/main/java/com/yas/product/service/ProductService.java
Outdated
Show resolved
Hide resolved
product/src/main/java/com/yas/product/service/ProductService.java
Outdated
Show resolved
Hide resolved
product/src/main/java/com/yas/product/service/ProductService.java
Outdated
Show resolved
Hide resolved
product/src/main/java/com/yas/product/exception/InternalServerErrorException.java
Outdated
Show resolved
Hide resolved
product/src/main/java/com/yas/product/service/ProductService.java
Outdated
Show resolved
Hide resolved
Quality Gate passed for 'storefront'Issues Measures |
Quality Gate passed for 'backoffice'Issues Measures |
Quality Gate passed for 'product'Issues Measures |
Test Cases
1. The product name contains the option value
Create screen
Created successfully
2. The first option value contains the value of the second option value
Create screen
Created successfully