You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove integration test dependencies from children poms
Config to parent pom to add src/it/java and src/it/resources to maven testSourcePath and maven testResourcePath according to discussion in 22/08 daily meeting
Add failsafe plugin execution and config to run integration tests from src/it/java to parent pom
Tests for module tax as proof of concept
This pull request does not include:
Refactor test folder structures of existing test code (this should be done in a separate pull request)
Current test config:
All test file end with Test.java will be run by maven-surefire-plugin (So you should name your unit test with Test at the end for maven to pick it up)
All test file end with IT.java will be run by maven-failsafe-plugin (So you should name your integration test with IT at the end for maven to pick it up)
Both plugins will run in test phase of maven build cycle
Hi, @hnd14
I have a few generic comments. Please take a look and bring to discussion if needed.
We should discuss and agree with Team on whether a shared library for common test support should be created. There is a lot of duplicate code in the tests across services.
Unit tests and Integration tests:
Start with Unit tests to cover every component.
Integration test is expensive and slow. So, use them for specific scenarions involving critical/key interactions only. For example, convert TaxRateRepositoryIntegrationTest to Unit test with in-memory database (using @DataJpaTest) instead of PostgreSQL container)
Avoid hard-coding. Extract commonly used values, such as API paths - .get("/v1/backoffice/tax-classes") , into constants. It would help avoid issues if the API path changes.
Remove integration test dependencies from children poms
Config to parent pom to add src/it/java and src/it/resources to maven testSourcePath and maven testResourcePath according to discussion in 22/08 daily meeting
Add failsafe plugin execution and config to run integration tests from src/it/java to parent pom
Tests for module tax as proof of concept
This pull request does not include:
Refactor test folder structures of existing test code (this should be done in a separate pull request)
Current test config:
All test file end with Test.java will be run by maven-surefire-plugin (So you should name your unit test with Test at the end for maven to pick it up)
All test file end with IT.java will be run by maven-failsafe-plugin (So you should name your integration test with IT at the end for maven to pick it up)
Both plugins will run in test phase of maven build cycle
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for pull request:
src/it/javaandsrc/it/resourcesto maventestSourcePathand maventestResourcePathaccording to discussion in 22/08 daily meetingsrc/it/javato parent pommaven-surefire-plugin(So you should name your unit test with Test at the end formavento pick it up)maven-failsafe-plugin(So you should name your integration test with IT at the end formavento pick it up)testphase ofmavenbuild cycle