[Paypal-payment] Bill Pugh Singleton Implementation in PaymentProviderHelper.class

[LEHOANGGLAM]

• Update the PaymentProviderHelper to Singleton Instance to avoid creating multiple PaymentProviderHelper instances and conserve memory

[sonarcloud]

[payment-paypal] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

[thiennn]

I think the previous code is fine and simple. PAYPAL_PAYMENT_PROVIDER_ID is static and final. We don't need to create instance to access it

[khoahd7621]

In my perspective, apply singleton for PaymentProviderHelper is not necessary and cumbersome.
Static variable is class-based, not object-based. So static variable only loads one time when class is loaded at runtime.
Singleton will create a redundant object in memory for nothing purpose. The old implementation was fine.
Wait for the comments of anh @thiennn and anh @loinguyen-nt