#1149 - [Search][Recommendation] Introduce Kafka Stream to aggregate … #1233
Conversation
Recommendation Coverage Report
|
PhuocNguyenBa
force-pushed
the
feature/yas-1149
branch
3 times, most recently
from
9665f64
to
3145ba4
Compare
…all product data. -implement kafka stream application to capture all changes related to product
PhuocNguyenBa
force-pushed
the
feature/yas-1149
branch
from
25d6d7f
to
f98e6d4
Compare
|
PhuocNguyenBa
requested review from
khanhtrand,
minhtridn2001,
duylv27 and
chinhduongthi
|
Hi @PhuocNguyenBa, could you help to add your kafka-ui image to docker-compose file. It supports us to interact with message better than the |
| * @param <V> the type of values in the store | ||
| * @return a Materialized configuration for the store | ||
| */ | ||
| protected <K, V> Materialized<K, V, KeyValueStore<Bytes, byte[]>> createMaterializedStore( |
There was a problem hiding this comment.
Seems this one haven't enabled log compacted, could you help to confirm?
| .join( | ||
| nonNullProductCategoryTable, | ||
| (productCategoryDetail, nonNullProductCategoryDetail) -> { | ||
| if (productCategoryDetail.getId().equals(-1L)) { |
There was a problem hiding this comment.
Using this approach to check for deleted cases doesn’t make sense. In the future, if there is master data with id: -1, will it be identified as deleted?
We should define a flag in BaseMetaDataDto to serve all cases.
recommendation/src/main/java/com/yas/recommendation/topology/ProductTopology.java
Show resolved
Hide resolved
| KTable<Long, ProductCategoryDto> productCategoryTable = | ||
| createProductCategoryTable(streamsBuilder); | ||
|
|
||
| KTable<Long, ProductCategoryDto> nonNullProductCategoryTable = |
There was a problem hiding this comment.
Could you explain, why we need to create a mv to store value:null records here?
|
|
||
| @Override | ||
| @Autowired | ||
| protected void process(StreamsBuilder streamsBuilder) { |
There was a problem hiding this comment.
Seems we haven't aggregated product image data into sink topic, could you help to check?
…all product data.
-implement kafka stream application to capture all changes related to product