Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1180-return-payment-id #1232

Conversation

nashtech-tuannguyenhuu1
Copy link
Contributor

#1180-return-payment-id

Copy link

github-actions bot commented Oct 24, 2024

Order Coverage Report

Overall Project 78.55% -1.34%
Files changed 90.28% 🍏

File Coverage
OrderStatusConsumer.java 100% 🍏
CheckoutPaymentVm.java 100% 🍏
CheckoutMapper.java 100% 🍏
CheckoutState.java 95.71% 🍏
CheckoutProgress.java 95.24% -4.76% 🍏
PaymentService.java 82.76% -17.24% 🍏
PaymentMethod.java 78.13% -21.88% 🍏
CheckoutService.java 75.68% 🍏
JsonUtils.java 57.14% -42.86%
Constants.java 0% 🍏

Copy link

github-actions bot commented Oct 24, 2024

Payment Coverage Report

Overall Project 70.29% -2.92%
Files changed 73.49% 🍏

File Coverage
PaymentStatus.java 100% 🍏
CheckoutPaymentVm.java 100% 🍏
InitPaymentRequestVm.java 100% 🍏
PaymentService.java 95.96% -1.01% 🍏
OrderService.java 81.82% 🍏
PaypalHandler.java 11.63% -10.47%
PaymentController.java 0% -45.83%

@nashtech-tuannguyenhuu1 nashtech-tuannguyenhuu1 force-pushed the #1180-return-payment-id-for-tracking-purpose branch 9 times, most recently from 7017f3b to 1ae382b Compare October 25, 2024 03:05
@khanhduzz
Copy link
Contributor

khanhduzz commented Oct 25, 2024

Hello @nashtech-tuannguyenhuu1:

  • I wanted to bring up a potential change regarding the implementation of the Kafka topic and CDC event for the checkout process. Due to performance concerns, I'm unsure if this implementation is still suitable.

  • It seems that the workflow might be revised soon, with a potential shift to directly calling the backend API from the storefront. I am currently working on task [Order Refactor] Process to checkout - Kafka topic and CDC event for full fill Checkout #1230 but will need to wait for the updated design before proceeding.

The red rectangle will be updated with a new design soon, and we may no longer use CDC, which could impact your implementation. So, please consider take a look about it, thank you!

Screenshot 2024-10-24 151524

@nashtech-tuannguyenhuu1 nashtech-tuannguyenhuu1 force-pushed the #1180-return-payment-id-for-tracking-purpose branch 4 times, most recently from 4fabadf to 51e4e45 Compare November 5, 2024 01:42
Copy link

github-actions bot commented Nov 5, 2024

Payment Paypal Coverage Report

Overall Project 80.24% 🍏
Files changed 100% 🍏

File Coverage
PaypalCreatePaymentRequest.java 100% 🍏
PaypalService.java 100% 🍏

@nashtech-tuannguyenhuu1 nashtech-tuannguyenhuu1 force-pushed the #1180-return-payment-id-for-tracking-purpose branch from 51e4e45 to 2a30acc Compare November 5, 2024 02:38
Copy link

sonarcloud bot commented Nov 5, 2024

Copy link

sonarcloud bot commented Nov 5, 2024

Copy link

sonarcloud bot commented Nov 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants