Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1223 Implement mock APIs for delivery service #1231

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

#1223 Implement mock APIs for delivery service #1231

wants to merge 3 commits into from

Conversation

mochacr0
Copy link
Contributor

@mochacr0 mochacr0 commented Oct 24, 2024 •
edited
Loading

Summary

Implemented the following mock APIs:

  • Get all available shipment providers API
  • Calculate shipment fees API

image

@mochacr0 mochacr0 marked this pull request as ready for review October 24, 2024 17:13
@mochacr0 mochacr0 linked an issue Oct 25, 2024 that may be closed by this pull request
[Order Refactor] [Delivery] Implement delivery mock APIs for checkout/order processing #1223
Open
@mochacr0 mochacr0 removed a link to an issue Oct 25, 2024
[Order Refactor] [Delivery] Implement delivery mock APIs for checkout/order processing #1223
Open
@mochacr0 mochacr0 marked this pull request as draft October 28, 2024 10:36
@mochacr0 mochacr0 marked this pull request as ready for review October 29, 2024 08:39
nashtech-diepnguyenngoc1
nashtech-diepnguyenngoc1 requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@nashtech-diepnguyenngoc1 nashtech-diepnguyenngoc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests for the service and controller!

@mochacr0 mochacr0 marked this pull request as draft November 13, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nashtech-diepnguyenngoc1 nashtech-diepnguyenngoc1 nashtech-diepnguyenngoc1 requested changes

@nguyenvanhadncntt nguyenvanhadncntt nguyenvanhadncntt approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Yas's backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mochacr0 @nguyenvanhadncntt @nashtech-diepnguyenngoc1