Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1218 - Fix product attribute mapping and backoffice UI #1221

Merged
merged 2 commits into from
Oct 23, 2024
Merged

#1218 - Fix product attribute mapping and backoffice UI #1221

merged 2 commits into from
Oct 23, 2024

Conversation

khanhduzz
Copy link
Contributor

  • Fix product attribute mapping to return the correct data
  • Fix edit product in backoffice UI, do not force user to change the product price if not need

Issue: #1218

@khanhduzz khanhduzz changed the title fix product attribute mapping and UI #1218 - Fix product attribute mapping and backoffice UI Oct 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

Product Coverage Report

Overall Project 78.07% -0.04% ❌
Files changed 96.88% 🍏

File Coverage
ProductService.java 78.08% -0.1% 🍏

@khanhduzz khanhduzz marked this pull request as ready for review October 23, 2024 07:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed for 'backoffice'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed for 'product'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@khanhduzz khanhduzz linked an issue Oct 23, 2024 that may be closed by this pull request
[Product] Wrong mapping attributes when return product information in backoffice #1218
Closed
@khanhtrand khanhtrand merged commit d8b6d28 into main Oct 23, 2024
10 checks passed
@khanhtrand khanhtrand deleted the #1218-product-attributes branch October 23, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mochacr0 mochacr0 mochacr0 approved these changes

@khanhtrand khanhtrand khanhtrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Product] Wrong mapping attributes when return product information in backoffice
3 participants
@khanhduzz @khanhtrand @mochacr0